dopamine icon indicating copy to clipboard operation
dopamine copied to clipboard

Loss of responsiveness when importing a lot of songs

Open digimezzo opened this issue 1 year ago • 18 comments

Reported by a user:

I have imported over 14000 songs in dopamine. Now the whole software has become way much slower and less responsive. Is there anything I can do about it?

TODO: perform test with 14000 songs.

digimezzo avatar Sep 04 '24 11:09 digimezzo

If you want me to give you video of the problem, I would be happy to help.

Root1-2 avatar Sep 04 '24 13:09 Root1-2

@Root1-2 Yes, a video would be very helpful. Thank you.

digimezzo avatar Sep 04 '24 13:09 digimezzo

https://streamable.com/uaj9ku

You can see in the timestamp how it's stuck in 1:20, that's usually what happened when I try to navigate.

Root1-2 avatar Sep 04 '24 13:09 Root1-2

@Root1-2 I found the source of the problem. It's the sorting of the tracks by album that is slow. If you change it to A-Z or Z-A performance should be much better. I'm working on a fix. I should be able to get you a build with a fix for all the sorting types tomorrow.

digimezzo avatar Sep 04 '24 21:09 digimezzo

@Root1-2 This nightly build has the fix. Could you try it out? https://github.com/digimezzo/dopamine/actions/runs/10717657882

digimezzo avatar Sep 05 '24 09:09 digimezzo

Tried the version you gave me. Same problem. Here is the new problem video:

https://streamable.com/l8alip

Root1-2 avatar Sep 05 '24 11:09 Root1-2

@Root1-2 That's bad news. Could you attach you log file here?

digimezzo avatar Sep 05 '24 11:09 digimezzo

How to create a log file?

nvm. Got it.

Dopamine.log

Root1-2 avatar Sep 05 '24 11:09 Root1-2

You can open the folder that contains the log file from the settings screen:

image

digimezzo avatar Sep 05 '24 11:09 digimezzo

Uploaded in the above comment.

Root1-2 avatar Sep 05 '24 11:09 Root1-2

@Root1-2 I made soem more adjustments. Could you try out this build and make a video so I can see how it performs on your system: https://github.com/digimezzo/dopamine/actions/runs/10745342673 Thanks

digimezzo avatar Sep 06 '24 21:09 digimezzo

https://streamable.com/78qdq0

It's fixed now. Thank you.

One tiny suggestion though, when navigating to various section (Album, Songs, Artists etc), the song data is fetched again. You can prevent it by caching the data though, right?

Root1-2 avatar Sep 06 '24 22:09 Root1-2

Thanks for testing it out. Loading artists is still slow, but I expected that. I'm working on improving that. Albums and tracks now load fast. For fetching the tracks each time: each screen has it's own list. So caching or not, the list needs to be filled in and even with caching it would behave like it is now. But I'll see if I can improve that.

digimezzo avatar Sep 07 '24 04:09 digimezzo

Thank you for your time man. Here's to another year of using Dopamine

Root1-2 avatar Sep 07 '24 08:09 Root1-2

Thank you for your time man. Here's to another year of using Dopamine

You're welcome. Thanks for your help and for using Dopamine.

digimezzo avatar Sep 07 '24 08:09 digimezzo

@Root1-2 I've now fixed the loading of artists too. Could you try this build out and record a video for the last time so I can see how it responds for you: https://github.com/digimezzo/dopamine/actions/runs/10761663576 Thank you!

digimezzo avatar Sep 08 '24 17:09 digimezzo

It's running much faster now. Thanks man. Here is the video of me running the latest version.

https://streamable.com/e5v0b3

Root1-2 avatar Sep 08 '24 17:09 Root1-2

@Root1-2 You're welcome. Thansk for spending the time to test it out and making the videos. It was very helpful!

digimezzo avatar Sep 08 '24 18:09 digimezzo