lumen-graphql icon indicating copy to clipboard operation
lumen-graphql copied to clipboard

Investigate if we really need TypeResolver at all

Open Jalle19 opened this issue 6 years ago • 2 comments

While working on a side project I realized that resolveType() is not called anywhere, so it's pointless to provide a more complex implementation than return null;.

Jalle19 avatar Feb 07 '18 20:02 Jalle19

It's really weird to me, why we even refactory the TypeResolver class but we've never used it before? :-?

hungneox avatar Feb 08 '18 10:02 hungneox

@hungneox it seems like it's being used in the 1.4.x version of the library, but not in 1.5 and newer which is what we have here.

Jalle19 avatar Feb 08 '18 11:02 Jalle19