digger icon indicating copy to clipboard operation
digger copied to clipboard

Support case insensitive digger commands

Open motatoes opened this issue 2 years ago • 11 comments

Requested by user:

Digger commentOps currently only work with exact lowercase "digger plan", "digger apply" etc.

Digger should be able to also support case insensitve commands such as "Digger plan" and so on since it is more forgiving.

Proposal: make digger case insensitive by default, allow users to make it case sensitive through some parameter passed into composite action case-sensitve (defaults to false)

motatoes avatar Jun 08 '23 16:06 motatoes

I'd like to work on this issue

SamantaTarun avatar Jun 09 '23 01:06 SamantaTarun

@tarunsamanta2k20 sure! I'll assign it to you, any questions just ask on here or on our slack :)

motatoes avatar Jun 09 '23 07:06 motatoes

hey @tarunsamanta2k20 how's it going on your end ?

motatoes avatar Jun 13 '23 13:06 motatoes

@motatoes how to test it by running the command locally?

Where is your composite action located?

SamantaTarun avatar Jun 14 '23 20:06 SamantaTarun

Hey @tarunsamanta2k20 you can write a unit test or you can test it by forking one of the demo repositories and creating a pull request from it https://github.com/diggerhq/digger_demo_multienv

Feel free to create a pull request and I will test on your behafl

motatoes avatar Jun 14 '23 21:06 motatoes

@motatoes in which file should i make changes to? digger.Go?

SamantaTarun avatar Jun 15 '23 00:06 SamantaTarun

@tarunsamanta2k20 can you please join our slack channel we can discuss it there :)

motatoes avatar Jun 15 '23 07:06 motatoes

@tarunsamanta2k20 can you please join our slack channel we can discuss it there :)

Please send your slack url over here.

SamantaTarun avatar Jun 15 '23 08:06 SamantaTarun

check the link in the README for joining slack

motatoes avatar Jun 15 '23 08:06 motatoes

Is this issue still open ?

AHB102 avatar Aug 09 '23 05:08 AHB102