digger icon indicating copy to clipboard operation
digger copied to clipboard

Custom steps should not fail the workflow

Open ZIJ opened this issue 1 year ago • 1 comments

Wouldn't be more practical if the checkov tests results including both Failed and Passed are commented in PR, as it would be easier to read what has to be changed rather scrolling in the runner logs and having a failed workflow?

  • workflow job to succeed
  • custom step (checkov) failure reported as a comment instead

I think if it doesn't pass the checks then having the workflow job to fail is a fine, but it should say why it failed, as you suggested as a custom step (checkov) failure reported as a comment.

Reported by the user A.D in support

ZIJ avatar Feb 23 '24 14:02 ZIJ

I think if a custom step returns non zero status it should still be considered as a failed workflow

motatoes avatar Feb 23 '24 15:02 motatoes