chore(cli): add designsystemet theme
lay the groundwork for #3541
- Default theme is called
designsystemet - Edit config file
packages/theme/configs/designsystemet.config.jsonfor default theme. - Run
pnpm update:themeto build new css and tokens for default theme. - Refactored some configs use in CLI
- Fixed wrong quotation marks for
@charsetin css package design-tokenslater when we figure out how we want to handle Digdirs themes.- Theme is used in themebuilder, storybook and css as default theme.
- design-tokens for theme are stored in
internal/design-tokensfor now, but can be move later depending on what we figure out to do with digdirs themes.
Default theme is currently exported under @digdir/designsystemet-theme/default, we will have to change main export at a later point when we decide how to move forward with this.
🦋 Changeset detected
Latest commit: 4922d25cada01ab6480d7079bd2b90d76ea1dfba
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
| Name | Type |
|---|---|
| @digdir/designsystemet-css | Patch |
| @digdir/designsystemet | Patch |
| @digdir/designsystemet-react | Patch |
| @digdir/designsystemet-theme | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Preview deployments for this pull request:
Storybook - 20. May 2025 - 14:05
Theme - 20. May 2025 - 14:05
Coverage Report
| Status | Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔵 | Lines | 49.12% | 3311 / 6740 |
| 🔵 | Statements | 49.12% | 3311 / 6740 |
| 🔵 | Functions | 83.26% | 219 / 263 |
| 🔵 | Branches | 77.85% | 580 / 745 |
File Coverage
No changed files found.
@digdir/designsystemet-css is now bundles with default theme...
I think it belongs in our theme package. It's not a big obstacle to install a secondary package to get colors. If we put it in the css package it's easy to get confused as to why we have a theme package at all.
You mention "Could potentially be opt-in with a different export", but if we just put it in the theme package we won't have to do any of this.
Should the default theme be called, default or designsystemet?
I vote for designsystemet
@digdir/designsystemet-css is now bundles with default theme...
I think it belongs in our theme package. It's not a big obstacle to install a secondary package to get colors. If we put it in the css package it's easy to get confused as to why we have a theme package at all.
You mention "Could potentially be opt-in with a different export", but if we just put it in the theme package we won't have to do any of this.
Should the default theme be called, default or designsystemet?
I vote for designsystemet
yeah, I agree, I actually started refactoring it this morning for the theme and its config to be in @digdir/designsystemet-theme, felt much better.
Code looks good, but we need to define the colors used in this theme before merging