core icon indicating copy to clipboard operation
core copied to clipboard

AttachPlayer loosing interactivity

Open girayk opened this issue 1 year ago • 3 comments

When we call Composition.attachPlayer its creating new canvas 2D element and its not binding some pixi events such as onmouseleave Maybe its better instead of creating new Canvas element, returning renderer.view.canvas then we can bind reactivities.

public attachPlayer(element: HTMLElement) { element.appendChild(this.renderer.view.canvas); }

girayk avatar Oct 02 '24 08:10 girayk

The reason why we don't use the Pixi canvas is so that we can change the resolution during rendering. Otherwise the canvas would be rescaled. But I agree that we should propagate the events

k9p5 avatar Oct 17 '24 19:10 k9p5

👍🏻

girayk avatar Oct 17 '24 22:10 girayk

I'll leave it open until the changes were merged

k9p5 avatar Oct 18 '24 02:10 k9p5