spotless Enforce var jdk11 applied

This mirrors https://github.com/diffplug/spotless/pull/1578 , and in addition it applied the mutator to the whole repository through:

mvn io.github.solven-eu.cleanthat:cleanthat-maven-plugin:apply -Dcleanthat.mutators=RSPEC-6212
./gradlew spotlessApply

(I relies on cleanthat mvn plugin not to have to drop the ratchetFrom parameter, and other steps, to force a full-process by Spotless).

Then, you can review the result of this rule.

Typically, some var may be missing due to lack of context (as each File is processed on a per-file basis)

Mar 07 '23 06:03 blacelle

> Task :lib-extra:javadoc FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':lib-extra:javadoc'.
> Javadoc generation failed. Generated Javadoc options file (useful for troubleshooting): '/home/runner/work/spotless/spotless/lib-extra/build/tmp/javadoc/javadoc.options'

Would :lib-extra:javadoc not accept JDK11+ source code?

Mar 07 '23 07:03 blacelle

Wow, this is great, thanks! Re: javadoc, yes our javadoc generation is currently stuck at 8, I fixed it over here

https://github.com/diffplug/spotless/pull/1524/commits/d6c5ac2597846830f018af4f187bfaa5160104d5

but I haven't had time to get this merged yet. This PR will create a ton of merge conflicts, so I want to delay merging until the lint stuff has been merged. I've been swamped by just day-to-day maintenance recently, haven't had time to take on the structural issues.

Mar 07 '23 17:03 nedtwigg

@nedtwigg This has been resynced with main. Ready-for-merging

Mar 30 '23 05:03 blacelle

I want to delay merging until the lint stuff has been merged.

Blocked on

#1096
#1097

Apr 05 '23 22:04 nedtwigg