goomph icon indicating copy to clipboard operation
goomph copied to clipboard

FileMisc throws an unexpected exception when a download fails

Open yohoe opened this issue 4 years ago • 1 comments

FileMisc.download(..) throws an IllegalArgumentException when a download fails (e.g. 404), but PdeInstallation and P2BootstrapInstallation expect it to throw FileNotFoundExcpetion in order to try alternative uris.

Workaround in my case is to append the version to goomph_override_p2bootstrapUrl so that the first try is successful, but this is less flexible.

yohoe avatar Aug 24 '21 18:08 yohoe

Thanks for reporting, PR's welcome.

nedtwigg avatar Aug 24 '21 18:08 nedtwigg

The EquoIDE plugins use okhttp instead of the janky FileMisc stuff, this issue is almost certain solved if you migrate to dev.equo.ide or dev.equo.p2deps. https://github.com/equodev/equo-ide/tree/main/plugin-gradle

nedtwigg avatar Mar 01 '23 00:03 nedtwigg