diesel icon indicating copy to clipboard operation
diesel copied to clipboard

Allow for "bool" type from django

Open ianeli1 opened this issue 2 years ago • 1 comments

Hey all.

Encountered this issue while attempting to modernize a Django app by running diesel print-schema on an already created SQLite3 db, which returned Unsupported type: bool.

Django appears to have used "bool" for their types instead of "boolean".

ianeli1 avatar Jul 20 '22 05:07 ianeli1

I'm fine with this change as long as the PR includes a test for this. Tests for diesel cli should be added here

weiznich avatar Jul 20 '22 06:07 weiznich

Has there been any progress on this? It would be hugely beneficial for rewriting backends to rust without having to modify or migrate the existing databases.

social-anthrax avatar May 17 '23 14:05 social-anthrax

@social-anthrax This PR (as any open PR) waits on someone to move it forward. Your contributions are welcome here. Otherwise its discouraged to ask for updates on PR's.

weiznich avatar May 17 '23 14:05 weiznich

@weiznich My apologies, I missed the next steps for moving this PR forward and assumed that it had simply fallen through the cracks. I'll take a look at implementing the tests when I have time

social-anthrax avatar May 17 '23 15:05 social-anthrax

Closed by #3632

weiznich avatar May 19 '23 16:05 weiznich