MIToS.jl icon indicating copy to clipboard operation
MIToS.jl copied to clipboard

Formatting -> Format

Open timholy opened this issue 1 year ago • 2 comments

Formatting.jl is now archived.

EDIT: This also adds [compat] bounds on stdlibs, and makes Julia 1.6 the minimum supported version.

timholy avatar May 10 '24 19:05 timholy

Test failures expected from #73. Fortunately the PDB tests run before the Pfam tests.

timholy avatar May 10 '24 20:05 timholy

Hmm, looks like we have to drop Julia 1.0 if we're going to do this. I've tentatively made Julia 1.6 the minimum. I've also done a minor bump, since you're supposed to when you drop support for older Julia versions.

timholy avatar May 10 '24 20:05 timholy

Test failures are because Interpro throttles the number of simultaneous users. There may not be much reason to test unix/windows/mac, perhaps just one would suffice.

timholy avatar May 31 '24 09:05 timholy

Hi @timholy, thank you so much for tackling this; it was on my todo list for a while :)

Yes, making 1.6 the minimum Julia version makes sense, as it is the LTS version. I was trying to keep compatibility with older Julia versions, as the official version in my institute's cluster is 1.5. I think that old Julia versions could also be present in other academic HPC systems. However, developing such old Julia versions becomes complicated as the ecosystem evolves, so let's move on to 1.6 as the minimum.

Yes, testing the download in a single OS makes sense to avoid that problem.

diegozea avatar May 31 '24 15:05 diegozea

as the official version in my institute's cluster is 1.5

My condolences 😆

timholy avatar Jun 06 '24 10:06 timholy