react-pdf icon indicating copy to clipboard operation
react-pdf copied to clipboard

Hotfix: issue #1805 by not using the cache for images from a buffer

Open 13Bytes opened this issue 2 years ago • 6 comments

Hi, this is a Hotfix for #1805. It will disable caching for images from a buffer, until someone comes up with a better solution.

13Bytes avatar Jul 15 '22 12:07 13Bytes

Hi, it would be great if this (or a different solution to this bug) could be released, as it currently blocks a project I'm working on : /

13Bytes avatar Aug 19 '22 06:08 13Bytes

hi, I use the buffer image in the browser, and the displayed images are all the same. Will this patch fix it?

greenking19 avatar Aug 22 '22 16:08 greenking19

@greenking19 Yes, it does

13Bytes avatar Aug 26 '22 07:08 13Bytes

@13Bytes I pulled this pr, but I don't know how to use it. How can I use this? I don't know how to use it after using 'npm run build', unlike a normal package😯

greenking19 avatar Aug 26 '22 08:08 greenking19

@13Bytes I pulled this pr, but I don't know how to use it. How can I use this? I don't know how to use it after using 'npm run build', unlike a normal package😯

Since this is just the source-code, you need to set up the repo as described here: https://github.com/diegomura/react-pdf/blob/master/.github/CONTRIBUTING.md#set-up-your-development-environment After that, you can build (this branch) and use the artifacts.

13Bytes avatar Aug 26 '22 08:08 13Bytes

@13Bytes It looks like a lot of trouble. I'm now replacing it with base64. Hopefully this pr will merge soon

greenking19 avatar Aug 26 '22 09:08 greenking19