react-pdf icon indicating copy to clipboard operation
react-pdf copied to clipboard

Allow passing credentials: 'include' when fetching image from external url.

Open carloscastrodev opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe.

  • I have a cloudfront distribution where I use signed cookies to access the content, thus I have to fetch it with credentials: 'include' in order to use the cookie on the request.

Describe the solution you'd like

  • Allow passing a property to <Image /> component that enables credentials: 'include' on the request for that image.

Describe alternatives you've considered

  • None.

Additional context

  • My current workaround is to patch the library with a string replacement after installing dependencies and before building.

carloscastrodev avatar Jul 21 '21 03:07 carloscastrodev

I have the exact same issue.

Did you manage to find a better workaround or are we currently stuck with this?

I assume that implementing such a property to Image as you suggested should not be such a big deal.

Apporix avatar Aug 16 '21 23:08 Apporix

I have the same issue here. Any progress in this?

edit: I submitted this and tested it works for me. Let me know if you need to see any additional in this PR.

stonesthatwhisper avatar Nov 16 '22 08:11 stonesthatwhisper

Should be fixed with #2130 ? So we could close this issue.

nikischin avatar Jun 01 '24 13:06 nikischin