Diego Muracciole comments

Results 180 comments of


                                            Diego Muracciole

React-PDF Unusable For Modern Packaging Systems & Server Side Rendering

Thanks @wojtekmaj and @jd-carroll for all the thoughts here! Criticisms were taken with ❤️. My only comment, if I might, is that the "unusable" part of the issue title is...

Image component can't render JPG image

We will need more details about error

Adding Naira symbol "₦" showing "¦"

Are you using a font that has that glyph?

Fix invalid JPEG image

> +1, surely it can't hurt rolling this even if a more correct fix exists right? This goes from broken to less (or not) broken, even if a more correct...

Fix invalid JPEG image

Agree. @ooga mind pushing that fix instead? Otherwise I can do in a separate PR

Fix invalid JPEG image

Should be fixed by https://github.com/diegomura/react-pdf/pull/2689. Thanks for the discussion here!

fix: CI workflow error & add separate reference files for different platforms

@wojtekmaj looks good but tests are failing

chore: add TypeScript as a dependency

Needs small rebase (sorry 😄 ) . @wojtekmaj I'm open to this, but not sure I see the usage if we aren't migrating to TS. Can you expand on how...

chore: update Yarn to v4; migrate from Lerna to Yarn Workspaces

I like this!

chore: update Yarn to v4; migrate from Lerna to Yarn Workspaces

@wojtekmaj this needs rebase 😄 Sorry, lots of changes going on recently