Diego Augusto Molina
Diego Augusto Molina
Hi! Greetings from the Release Guild. This is a friendly reminder that the Steady [11.2.x Release Branch](https://github.com/grafana/grafana/tree/v11.2.x) was cut this week, and that it includes the changes committed up to...
I can fix this if you want, but I think I would need to make some non-trivial changes, so I will tell you the plan before doing any work to...
> But how functions from env will work? Currently, we call `expr.ConstExpr(name)` and it checks the environment. I think it would be good to keep this function as it looks...
Hey @antonmedv, I was wondering if you were able to check my last message, I just wanted to confirm it looks ok to you before doing any work.
@antonmedv I'm willing to work on this if you agree on it. Please, let me know your comments and if you would like to change anything so we agree before...
I apologize for not clarifying my expectations. I would have expected the sum to not overflow. The issue is that there is no `int64` builtin sum operation when running in...
In the code for `Add` in [vm/runtime/helpers[generated].go](https://github.com/expr-lang/expr/tree/eeb1b8b6259d9a34ad5fb06bdd8cde80841396ac/vm/runtime/helpers%5Bgenerated%5D.go#L2082) it shows (roughly): ```go func Add(a, b interface{}) interface{} { switch x := a.(type) { //... case int64: switch y := b.(type) {...
> Question: why you don't convert int64 to int32 on env creation? The goal is that I can have 64bit arithmetic on 32bit systems. It doesn't make sense to convert...
> I guess OpCall1, OpCall2 OpCall3 is kind of a same way of avoiding buffer allocation. What is the speedup? At first, I also thought that OpCall1, OpCall2, and OpCall3...
@antonmedv I answered above, let me know if you want me to try a different approach or if you think it's ok we could merge it.