Diego Marquez

Results 110 comments of Diego Marquez

> We had an issue with forking renovate, could you remove the renovate setting for now? cc: @blakeli0 @JoeWang1127 Could you explain more about the issue?

> > We had an issue with forking renovate, could you remove the renovate setting for now? cc: @blakeli0 > > @JoeWang1127 Could you explain more about the issue? We...

> In the pull request description, would you add a section "Message to library users (release note)"? > > What's rationale for CLIRR check failures? (Can you add the rationale...

`BatchingSettings`' new methods are covered with a new test suite `BatchingSettingsTest` Example [ci job](https://github.com/googleapis/sdk-platform-java/actions/runs/9405177370/job/25905766310?pr=1872): ``` [INFO] Running com.google.api.gax.batching.BatchingSettingsTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:...

> @diegomarquezp @blakeli0 I think I found the root cause of the sonar issues listed in #2520. > > I believe it's due to this line in the surefire maven...

The java-spanner downstream [check](https://github.com/googleapis/sdk-platform-java/actions/runs/9701427762/job/26775058213) is failing because a new method `attemptFailedDuration` was added to `BaseApiTracer`. ``` Error: Failures: Error: CompositeTracerTest.testMethodsOverrideMetricsTracer:238 Method not found in compositeTracerMethods: public void com.google.api.gax.tracing.MetricsTracer.attemptFailedDuration(java.lang.Throwable,java.time.Duration) ``` The...

@blakeli0 Do we only want to check autoconfig generation?

From discussion with @blakeli0, let's limit the scope to updating the generator

From https://github.com/googleapis/sdk-platform-java/actions/runs/8150253915/job/22276206879?pr=2460 ``` + /home/runner/work/sdk-platform-java/sdk-platform-java/output/protobuf-25.2/bin/protoc --experimental_allow_proto3_optional --plugin=protoc-gen-java_gapic=/home/runner/work/sdk-platform-java/sdk-platform-java/library_generation/gapic-generator-java-wrapper --java_gapic_out=metadata:/home/runner/work/sdk-platform-java/sdk-platform-java/output/temp_preprocessed/java_gapic_srcjar_raw.srcjar.zip --java_gapic_opt=transport=grpc,rest-numeric-enums,grpc-service-config=,gapic-config=,api-service-config=google/cloud/alloydb/connectors/v1/connectors_v1.yaml google/cloud/alloydb/connectors/v1/resources.proto google/cloud/common_resources.proto Error: Exception in thread "main" java.lang.IllegalStateException: No services found to generate at com.google.common.base.Preconditions.checkState(Preconditions.java:512) at com.google.api.generator.gapic.protoparser.Parser.parse(Parser.java:178) at com.google.api.generator.gapic.Generator.generateGapic(Generator.java:30) at com.google.api.generator.Main.main(Main.java:28)...

> @diegomarquezp I'm a little late to this, but is there a related issue I can review that this is trying to solve? @meltsufin https://github.com/googleapis/sdk-platform-java/issues/2050 I'm adding it to the...