Bug: Windows generact

[Geczy]

This shouldn't be happening. It works perfect in a unix environment but not my windows 10

[diegohaz]

This seems to be a problem with this function: https://github.com/diegohaz/generact/blob/master/src/utils.js#L11-L20

I don't have a Windows machine to test it. Could you try to change it?

[Geczy]

Parallels? Windows 10 vm's are free https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

[Shhzdmrz]

still not working on Windows 10 even not the extension of vs code.

[diegohaz]

Hi, guys. I'd appreciate very much if some Windows user could take this.

The problem seems to be with this function: https://github.com/diegohaz/generact/blob/638f95242d4572887802bbe0551974870e69c02f/src/utils.js#L12-L21

[Shhzdmrz]

I am willing to contribute please guide me how to setup the basic environment and how to test it.

[diegohaz]

Sure, @Shhzdmrz.

1. Fork the repo and clone it in your local machine (git clone https://github.com/Shhzdmrz/generact);
2. Change to the directory: cd generact;
3. Install dependencies with yarn or npm install;
4. Run tests with yarn test or npm test (if you're on Windows, some should fail);
5. Keep tests running with yarn test --watch or npm test -- --watch;
6. Update the code in src trying to make tests to pass.

Just make sure to run yarn lint before creating the PR.

[Shhzdmrz]

@diegohaz please check my forked branch with the comments I added.