Generator.Equals icon indicating copy to clipboard operation
Generator.Equals copied to clipboard

Remove the runtime dependency

Open diegofrata opened this issue 1 year ago • 3 comments

Another idea is to remove the runtime dependency, especially for those who don't use custom Comparers. They can be delivered explicitly (with global:: full typepaths to avoid possible collisions).

Originally posted by @HavenDV in https://github.com/diegofrata/Generator.Equals/issues/22#issuecomment-1225447457

diegofrata avatar Aug 24 '22 09:08 diegofrata

I don't see much gain in removing the runtime dependency only for cases without custom comparers, to me this is either all or nothing -- either we move all comparers to be source generated and get rid of the runtime dependency at all or we don't. It's a sizeable piece of work.

diegofrata avatar Aug 24 '22 09:08 diegofrata

The main problem is that the Runtime package has a dependency:

<PackageReference Include="Microsoft.Bcl.HashCode" Version="1.1.0" />

HavenDV avatar Aug 25 '22 02:08 HavenDV