rocketredis icon indicating copy to clipboard operation
rocketredis copied to clipboard

Problem with menu

Open filliperomero opened this issue 4 years ago • 3 comments

I saw that we are creating a menu in main.ts (electron) but this menu is not showing in Windows/linux (because of the custom Header). It only shows in Mac because MacOS handles different the menu.

The idea is to only show in MacOS or it is suppose to show in others platform?

If the answer is for all plataforms, I am thinking on fixing it putting the menu in the Header component but we don't a layout for it (one with the menu). Some insights would be good, so I can work on it.

filliperomero avatar Jan 14 '21 18:01 filliperomero

Hi @filliperomero, i'm using Kubuntu and it shows the menu for me, but the user have to configure the Application Menu. image Will try to test it on windows, but i think that we can adapt Rocket Redis to work with the native header if the menu is that important to us :)

diego3g avatar Jan 15 '21 00:01 diego3g

hello @diego3g , looks like kubuntu has the same behavior as macos, putting the menu in the top of the screen. So, we end up with this problem only in windows, since windows does not have a menu in the top corner. image

We can get this menu and put in the custom header (vscode and hypder did that) if is that important for us to have this menu. We just need to think on how it will looks like on windows since the header has 2 layouts (mac style or normal style)

We can think about something like this: Hyper (for when the mac style is active) image or we can go for a more classic layout like VSCode image

Of course, all of these ideas are for windows only.

filliperomero avatar Jan 15 '21 13:01 filliperomero

That's great, i prefer the Hyper version as we have a custom header right now, what do you think?

diego3g avatar Jan 15 '21 18:01 diego3g