Cristiano Rastelli

Results 46 comments of Cristiano Rastelli

> @didoo I had another look at this PR to understand the remaining bits and pushed two commits. `SideNav::Base` is a very generic component, so I don't see a way...

> wanted to have a fallback to make sure we're not blocked. @alex-ju see my last two commits, let's see if they unblock the tests, and then we decide how...

> The approach to always have the button in the DOM with opacity 0 has usability flaws when the button overlaps another interactive element, such as a link on the...

> I've not tested `pointer-events`, it may allow the click to go through the button and reach the underneath target, but the issue I see with the button being in...

For context, re. the conversation started by @KristinLBradley above, we're continuing the exploration directly in code and we'll report here once we have come to a conclusion/decision.

For future context: we decided to re-organize our "dialog-related" components following this new structure: - Dialog - Dialog (the primitive) - Modal - Flyout But after doing all the refactoring,...

> The Flyout header is now `var(--token-color-surface-faint)` where previously was inheriting `var(--token-color-surface-primary)` from the root element (left is before, right is after). Yes, this is intentional. > Icons and Title...

> I added images and created a new sub folder within website/public/assets for dialog-primitives for shared assets. Wanted to confirm that everyone was ok with that? @majedelass not a blocker,...

> Is that a style we are trying to standardize for documentation? If it is, then maybe we should go down that path. @majedelass maybe sync with @jorytindall on this...

For context: I have moved a commit that @majedelass made to replace the header/body/footer component instances with static images ([context](https://github.com/hashicorp/design-system/pull/1918/files#r1481892451)) to the documentation branch (https://github.com/hashicorp/design-system/pull/1945/commits/f100a1a657e0abc3400dad3801aaddc9589296c2) to avoid any confusion of...