Denis-Adrian Cristea

Results 59 comments of Denis-Adrian Cristea

What version of `@discordjs/ws` are you on?

Sorta familiar with this issue. We've been trying to fix it for a while and across multiple PRs. You're not experiencing Discord constantly telling you to reconnect (at least to...

> Do you think it's an issue in the underlying WebSocket package? No.

`packages/ws/src/ws/WebSocketShard.ts` - mainly the `onClose` handler and the `destroy` method.

Hi! Are you still able to reproduce this issue on 0.4.1?

ready for review since unit testing any more of this would be hell without proper redis mocks ~~in hindsight, I still need to write doc comments before we can merge.~~...

> You have merge conflicts, @didinele fixed. moved to neon and back to tsup

Could you mess around with `file-type` (NPM) yourself and see what the recognized `mime` type is? I have a suspicion the fault arises from here: https://github.com/discordjs/discord.js/blob/0674820723ac9fe57cdd85acdd164a8a2305ea6d/packages/rest/src/lib/RequestManager.ts#L417 Especially considering that you...

> Could the issue be due to it not being image/png? It... sure sounds like it, which would make this an API bug(?), probably. > Interestingly enough, it works [...]...

That works too. Thanks! I'll try to flag this as an API bug and if that doesn't work we'll need to hack this up internally, but I hope they take...