Dictu icon indicating copy to clipboard operation
Dictu copied to clipboard

[WIP] - Feature/datetime work

Open briandowns opened this issue 1 year ago • 3 comments

Datetime Module

What's Changed:

Refactor Datetime module to be class based and add additional features. This is marked as draft / WIP in order to get feedback on the implementation. If acceptable, I'll complete this with docs, tests, etc, as well as squash the commits down some more.

I added a "duration" object but I'm wanting to rethink it some. I can add that functionality in another PR.

Type of Change:

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • [ ] Tests have been updated to reflect the changes done within this PR (if applicable).
  • [ ] Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

briandowns avatar Sep 30 '24 02:09 briandowns

Sorry I've been slow on this! Looks as though all the tests are failing so we will need to look into these!

Jason2605 avatar Nov 06 '24 16:11 Jason2605

I'll get them passing. Just wanted to make sure the approach is ok.

briandowns avatar Nov 06 '24 19:11 briandowns

Ah apologies mate! Yeah I like it, an object wrapper around the long value seems sensible to me :)

Jason2605 avatar Nov 06 '24 19:11 Jason2605