Export-To-Ghostfolio
Export-To-Ghostfolio copied to clipboard
General improvements
Added
- Devcontainer configuration for easier local dev which can also be used for Codespaces.
Changed
- Save the JSON pretty-printed when
DEBUG_LOGGINGis enabled for easier debugging - Changed the default input, output and cache directory path to
/var/tmp/e2g-(input|output|cache)as not everyone has write access to/varwhen running locally (or in the devcontainer/Codespace where we deliberately don't run as root) - Manual runs save the file to
/var/tmp/e2g-outputor the specified output dir instead of repo root so easily found and ignored by git - YahooFinanceService will retry with GBp if a symbol/ISIN isn't found with GBP as the UK has this annoying habit of mixing GBP and GBp but platforms like Freetrade don't differentiate.
- Removed a load of unnecessary white space - unplanned, but my VSCode config does this for me when I touch files.
- Moved samples to their own directory for a cleaner layout.
- Only run the docker builds in CI if the secrets are set.
- Reordered converters and watcher headers alphabetically as it makes it easier to maintain.
Fixes
- Removed duplicate
.jsonin several messages.
Checklist
- [x] Added relevant changes to README (if applicable)
- [x] Added relevant test(s)
- [x] Updated GitVersion file
🤔 I'm not sure why this is suddenly failing. It looks like a permissions issue, however you're already setting the pull-requests: write permission in this workflow 🤷.
🤔 I'm not sure why this is suddenly failing. It looks like a permissions issue, however you're already setting the
pull-requests: writepermission in this workflow 🤷.
I noticed this some time ago, so I created the separate issue #56 to look into this. At first glance, it looks like the settings are correct but somehow it doesn't work.
Merged and released under 0.10.0.
Thanks for the contribution!!