dickwolff
Add support for Freetrade
Added
- Support for Freetrade
As an aside, this is a smaller part of a bigger PR I've been working on in my fork which resolves a few issues and niggles I encountered when trying to add support for Freetrade. I know things like rearranging a repo can step on toes so I've left this PR to be solely about adding Freetrade as the repo stands.
If you like all the changes in my other PR and are happy to accept them, I'm happy to close this PR in favour of that one, or split it up into a number of smaller easier to review PRs.
Thanks for the PR (both actually). I will look into this in more detail soon (currently planning on Tuesday)!
Overall a good PR, a few small things I left in review for you to look at.
I also took a look at your other PR. I'm not opposed to do a repository shake-up. The current setup was a merge of two separate converters and it has become somewhat cluttery (regarding the sample files). I want to propose to do both PR's separatly. This way this new feature can be added first, and then I can review the reorganisation separatly. I do have some questions about that PR, so I'll add them there.
Merged! Thanks for the contribution!
I added comments to your other draft PR, feel free to open it as a merge to this repo!
Ah, you've not finished the review - note the "Pending". You need to click the "Review changes" button on the "Files changed" tab. I won't be able to see your review comments until then.