Export-To-Ghostfolio icon indicating copy to clipboard operation
Export-To-Ghostfolio copied to clipboard

XTB: Accept new export format

Open dickwolff opened this issue 9 months ago • 3 comments

Fixes

  • 🐛 XTB: Accept new export format (in CSV)

Checklist

  • [x] Added relevant changes to README (if applicable)
  • [x] Added relevant test(s)
  • [x] Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #190

dickwolff avatar Apr 04 '25 12:04 dickwolff

"""

Walkthrough

The pull request updates the XTB documentation and CSV conversion logic to accommodate changes in the XTB cash operations export template. The README now provides detailed, step-by-step instructions for exporting an Excel file, navigating to the “CASH OPERATION HISTORY” tab, and post-processing the resulting CSV file by removing extraneous lines. In the converter tests, the expected structure of the CSV has been updated by modifying delimiters and adjusting column counts. The CSV parsing logic in the XtbConverter class now includes updated conditions for identifying record types (handling alternative names for interest and dividend entries), converts US date formats to a European format using the dayjs library, and validates match results before processing records. No changes were made to external entity exports.

Assessment against linked issues

Objective Addressed Explanation
Update export instructions to reflect the new XTB cash operations template and guide CSV post-processing steps (#190)
Adapt CSV parsing logic to accommodate new template structure including changes in delimiters, header columns, and record type identification (#190)
"""
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 04 '25 12:04 coderabbitai[bot]

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 98% 0
src.converters 97% 91% 0
src.helpers 100% 100% 0
Summary 97% (1783 / 1830) 92% (1239 / 1348) 0

github-actions[bot] avatar Jul 05 '25 13:07 github-actions[bot]