Dibyo Mukherjee

Results 253 comments of Dibyo Mukherjee

Would still be nice to have some testing in this area

The pipelines project uses this: https://github.com/tektoncd/pipeline/blob/master/test/e2e-tests-upgrade.sh Prow config is here: https://github.com/tektoncd/plumbing/blob/master/prow/config.yaml#L1211-L1237 Thanks @sbwsg

hi @georgettica looking at the PagerDuty usage docs it does seem like payload validation would be hard with just CEL. A custom interceptor for PagerDuty sounds good. I'll mention that...

hey @georgettica you are on the right track. I'll work on adding better docs for writing cluster interceptors but in the meantime you can take a look at this PR...

> And to add this I will just add the custom interceptor? So, the PR I mentioned adds another cluster interceptor called add-pr-body so I thought it would be a...

@bigkevmcd yeah I think that would be a good addition!

hi @georgettica sorry for the delay - are you looking for a review of https://github.com/georgettica/pagerduty-tekton-interceptor or are you looking to get that merged into the triggers source tree?