ml-coursera-python-assignments icon indicating copy to clipboard operation
ml-coursera-python-assignments copied to clipboard

Grader outdated again?

Open desdoo opened this issue 3 years ago • 4 comments

Hey @dibgerge , I just stumbled across this repo over Reddit and was super happy to do the ML course in Python. However, I think the grader is not working as it wasn't taking my first warmUpExercise(), eventhough the outputted matrix seems to be correct.

Bildschirmfoto 2021-12-07 um 21 37 28 n

Am I doing something wrong or is the repo indeed outdated?

desdoo avatar Dec 07 '21 20:12 desdoo

Same problem

solutum avatar Dec 12 '21 16:12 solutum

There is a problem in the submission.py file, where the index is assumed to start at 1, but actually starts at zero. This results in the exercise part names displaying in the wrong order. The score and feedback is correct but the part name is incorrect.

You can fix this in two ways either:

line set the start value of the enumerate function to be = 1 (line 44, change is on line 44)

for index, part in enumerate(parts, start=1)

or change the part where the index is assumed to be ones based (change is on line 49) print('%43s | %9s | %-s' % (self.part_names[int(index)], score, part_feedback))

aesir321 avatar Dec 17 '21 17:12 aesir321

Confirmed, everything needs to be shifted upwards by one. Thanks for the fix, @aesir321

19007361 avatar Dec 19 '21 08:12 19007361

Thanks. This change is merged now.

dibgerge avatar Mar 31 '22 05:03 dibgerge