Stephanie DiBenedetto
Stephanie DiBenedetto
This is fixable and is inconsistent with other proto runtimes. However, it poses a compatibility problem. The issue is here: https://github.com/protocolbuffers/protobuf-javascript/blob/a428c58273abad07c66071d9753bc4d1289de426/generator/js_generator.cc#L290 The immediate workaround is to use underscore_naming style rather...
Good question. Internally, we are use to people deliberately disabling debug mode when moving to production. It's unclear what the best approach is for public distribution.
We should fix this. #6 should help with this.
Struct has to/fromJavascript methods to help with this. However, we don't have a general solution for proto3 JSON in this runtime.
This project doesn't release protoc itself (though this was filed at a time when both projects were 1 repo). We could potentially add the protoc-gen-js plugin to the npm package.
We don't support public imports, but this is a reasonable feature request.
There's likely an issue in the compiler's heuristics, but it's unclear how deal with this in the open source.
Agreed that we could generate a better type here. As far as we can tell, grpc-web is just generating the type reflecting what we do. In the meantime, if you...
It sounds like the issue is the way we manage exports in the code generator. We need to do a more typical assignment to exports here: https://github.com/protocolbuffers/protobuf-javascript/blob/a428c58273abad07c66071d9753bc4d1289de426/generator/js_generator.cc#L3696 it might work...
We understand this is a problem, but are unclear what the best solution would be.