bitmask-core icon indicating copy to clipboard operation
bitmask-core copied to clipboard

WIP/Docker test volumes

Open rustchain64 opened this issue 1 year ago • 6 comments

Testing the run command against the Dockerfile with:

docker run -d --restart always -p 7060:7070 -v /Applications/bitmask/bitmask-core/target/release:/app -v /var/lib/docker/volumes/my_data_volume:/_data --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.17 -e “CARBONADO_DIR=/data”

the volume mounts allow for updating source code, at the same time, writing to the volume data mount

rustchain64 avatar Jul 29 '23 22:07 rustchain64

Final docker RUN command THIS WRITES TO /mnt/storage/carbonado-docker docker run -it --user root --restart always -p 7060:7070 --mount type=bind,source=/mnt/storage/carbonado-docker,target=/tmp/bitmaskd/carbonado --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.0.6.2 -e “CARBONADO_DIR=/data” bash

rustchain64 avatar Aug 01 '23 00:08 rustchain64

Alright, that technically gets the job done, but it's inelegant. Can you make it check runtime env vars to set CARBONADO_DIR to /data/bitmaskd/carbonado/ ? Heck, I think that's fine to set even at compile time.

cryptoquick avatar Aug 01 '23 00:08 cryptoquick

I intent make a review that today, ok?

crisdut avatar Aug 02 '23 20:08 crisdut

Sounds good

cryptoquick avatar Aug 02 '23 20:08 cryptoquick

Had to move ENV to runtime in order for rust to pick it up in Carbonado-Core

Runtime

FROM rust:1.69-slim-buster AS runtime

ENV CARBONADO_DIR=/data/bitmaskd/carbonado/

rustchain64 avatar Aug 03 '23 01:08 rustchain64

Hunter, I will double check but I believe in regards to docker we where at 1.71 Rust , but had issues, that caused us to degrade back to 1.69.. I can pull the latest and rebuild and test. I was focused on the AWS infrastructure until now, But can double back on Bitmask Core, tomorrow. I will be working on Saturday. Wesley

On Fri, Aug 18, 2023 at 6:58 AM Hunter Beast @.***> wrote:

@.**** requested changes on this pull request.

Can we see if CI passes if this is updated against the latest development branch?

Also, I'd like to upgrade to the latest stable version of Rust, 1.71.1.

— Reply to this email directly, view it on GitHub https://github.com/diba-io/bitmask-core/pull/307#pullrequestreview-1584524466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWG7QTWLHS6UZ42ZCCJNJDXV5RF5ANCNFSM6AAAAAA24YLK5Y . You are receiving this because you authored the thread.Message ID: @.***>

rustchain64 avatar Aug 19 '23 04:08 rustchain64