devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

[Feature Request]: Upgrade SDL2-image

Open tsunamistate opened this issue 9 months ago • 2 comments

Feature Type

Other (please specify)

Describe

Current SDL2-image used from source for platforms that don't use system package (such as Android) is 2.0.5, which is 3 years old at this point

https://github.com/diasurgical/DevilutionX/blob/21fc5030fc65ed62410733f5a7cfa8544a312c62/3rdParty/SDL_image/CMakeLists.txt#L23

It also requires a workaround of IMG.c, which is no longer needed in recent versions, AFAIK

tsunamistate avatar Apr 01 '25 17:04 tsunamistate

Are there any specific features of fixes that we would specifically benefit from?

AJenbo avatar Apr 01 '25 21:04 AJenbo

  • Native CMake support
  • New SDL-image uses stb_image as a default backend for PNG and JPG, so we can drop libpng dependency
  • Updates to PNG decoding (example: PNG images with a palette are loaded as SDL surfaces with a palette from 2.8.0)

tsunamistate avatar Apr 02 '25 07:04 tsunamistate