[Issue Report]: Pickup gold from inventory

[locksoft]

Operating System

Nintendo Switch

DevilutionX version

1.5.4

Describe

This is still related to issue 6988 (https://github.com/diasurgical/DevilutionX/issues/6988), but I discovered another bug picking gold from inventory.

I know it's useless to pick gold from the stash but on Nintendo Switch, if you accidentally open the gold input form, then the game is stuck and there's no way to close it. You can only quit the game and restart it from the system. I think it's better to disable the function until it gets fixed or removed.

There also another problem related to inventory. If I try to select an amount of gold, the whole slot is picked instead:

http://gofile.me/6RvCQ/1kDvyGrft

If it's not considered worth of fixing (like the pickup from the stash) maybe it's better to disable the function.

Note: this issue is similar to 7780 (https://github.com/diasurgical/DevilutionX/issues/7780) but not identical, that's why I kept them separate.

To Reproduce

Open the form to choose gold amount to pickup and insert a number

Expected Behavior

Get the exact amount of gold I type

Additional context

No response

[StephenCWills]

Please upload your video here instead of gofile.

[locksoft]

As I said in the other post I tried to upload them here, but I got the message "Failed to upload". I think it may be related to the file size, they go from 31 to 76 MB. :(

[StephenCWills]

https://github.com/user-attachments/assets/e8fc8cf9-2fd0-4cdb-8ec9-05db8e83eee0

[AJenbo]

You can probably easily reduce there size by trans coding it, it's not like the quality is important here.

[AJenbo]

Open the form to choose gold amount to pickup and insert a number

Would you please focus more on making it clear how and when the issue happens, not suggested solutions or workarounds. Even with the video I'm not fully sure what's happening and I don't think disabling features is a good option if the issue can actually be solved.

[locksoft]

Open the form to choose gold amount to pickup and insert a number

Would you please focus more on making it clear how and when the issue happens, not suggested solutions or workarounds. Even with the video I'm not fully sure what's happening and I don't think disabling features is a good option if the issue can actually be solved.

If I use the action button on a slot with coins I should be able to type an amount of coins to pickup (splitting it). But, like the same operation on the stash, it doesn’t works: regardless the amount you type, you’ll end up picking up all the coin (in the stash, instead, you won’t pick up anything and there’s a case when you can’t close the input popup anymore and need to force quit the game).

[StephenCWills]

If I use the action button on a slot with coins I should be able to type an amount of coins to pickup (splitting it). But, like the same operation on the stash, it doesn’t works: regardless the amount you type, you’ll end up picking up all the coin

I suppose this happens because the Nintendo Switch on-screen keyboard does not actually include an Enter key that can be used to submit the gold splitting dialog. Your assumption that the Confirm button on the controller would submit the dialog is wrong; that button is working as intended by lifting the whole gold pile. However, given that we can't rely on the platform to provide an event for the Enter key, we should probably find a way to change how it works.

(in the stash, instead, you won’t pick up anything and there’s a case when you can’t close the input popup anymore and need to force quit the game).

This doesn't make sense, though. There are several controller buttons that can be used to dismiss the gold withdrawal popup. This sounds like a separate issue that probably wouldn't be fixed even if we resolve the inventory issue reported here. Please open a separate issue to report this one so we can track both issues independently.

Also, keep in mind that many of us do not actually own a Nintendo Switch console capable of running this game so it would be helpful if you provided a video to show exactly how to reproduce it and what happens when you press various buttons.

[locksoft]

I suppose this happens because the Nintendo Switch on-screen keyboard does not actually include an Enter key that can be used to submit the gold splitting dialog. Your assumption that the Confirm button on the controller would submit the dialog is wrong; that button is working as intended by lifting the whole gold pile. However, given that we can't rely on the platform to provide an event for the Enter key, we should probably find a way to change how it works.

Usually the "done" (confirm/submit) button on the keyboard works as an "enter" in games. Like when you have to choose a name for a character or insert other information: you type the value, press "done" (or the "+" button) and it works. Here in Diablo the behavior is weird, but I'll explain in issue https://github.com/diasurgical/DevilutionX/issues/6988 that I'm going to update in a few minutes with a new video.

Edit: topic updated: https://github.com/diasurgical/DevilutionX/issues/6988#issuecomment-2691715363

(in the stash, instead, you won’t pick up anything and there’s a case when you can’t close the input popup anymore and need to force quit the game). This doesn't make sense, though. There are several controller buttons that can be used to dismiss the gold withdrawal popup. This sounds like a separate issue that probably wouldn't be fixed even if we resolve the inventory issue reported here. Please open a separate issue to report this one so we can track both issues independently.

I tried my best to replicate it after I updated to 1.5.4 and I wasn't able to make it happen. I will keep an eye on it but maybe it was solved with some update.

Also, keep in mind that many of us do not actually own a Nintendo Switch console capable of running this game so it would be helpful if you provided a video to show exactly how to reproduce it and what happens when you press various buttons.

Sure, I'll do my best.