devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Character Panel - Resistances

Open kphoenix137 opened this issue 10 months ago • 4 comments

Depends on: https://github.com/diasurgical/devilutionX/pull/7713

Changes resistances to utilize narrow labels, since horizontal spacing isn't an issue with any amount of resistances. Additionally, we then have enough space to change "Resist Element" to "Element Resistance"

image

kphoenix137 avatar Feb 05 '25 22:02 kphoenix137

what's up with that damage btw?

qndel avatar Feb 06 '25 07:02 qndel

It'd be nice if the mana box were vertically aligned with the light res box, I think for that the resistances need to move 1px up

glebm avatar Feb 06 '25 09:02 glebm

Nice change.

The only suggestion/comment (other than spacing mentioned by @glebm ) is that it would be cool if there was a neater way to avoid the "Resistance" repetition by having some sort of "header" called "Resistances", and then have only the element names for each value, like "Magic", "Fire" and "Lightning" instead of "Magic Resistance", "Fire Resistance" and "Lightning Resistance", but that might require a larger overhaul of the UI due to spacing and consistency reasons.

julealgon avatar Feb 06 '25 16:02 julealgon

It'd be nice if the mana box were vertically aligned with the light res box, I think for that the resistances need to move 1px up

It brings me great pain that it's not aligned, and I didn't notice until you mentioned it

kphoenix137 avatar Feb 07 '25 03:02 kphoenix137