devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Cleanup Store code

Open kphoenix137 opened this issue 1 year ago • 5 comments

kphoenix137 avatar Sep 17 '24 22:09 kphoenix137

I think I'll submit a PR separately that changes the variable names found in stores.cpp so this PR is much easier to review.

kphoenix137 avatar Sep 19 '24 13:09 kphoenix137

I think you should, this one already has conflicts despite being the latest

AJenbo avatar Sep 19 '24 13:09 AJenbo

Do your self a favor and merge master rather then rebase on it with the commits you have.

AJenbo avatar Sep 20 '24 23:09 AJenbo

There appears to be a critical issue with selling items. I noticed that sometimes the correct amount of gold is received, and other times the complete wrong amount is received.

EDIT: Fixed!

kphoenix137 avatar Mar 15 '25 17:03 kphoenix137

4 files have conflicts

AJenbo avatar Mar 15 '25 21:03 AJenbo