devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Fix Wall Spells

Open kphoenix137 opened this issue 1 year ago • 4 comments

Fixes: https://github.com/diasurgical/devilutionX/issues/7205

Fixes the problem where wall spells create visible missiles that overlap in the center of the wall, resulting in double damage.

kphoenix137 avatar Jul 25 '24 19:07 kphoenix137

why touch all that whitespace stuff?

qndel avatar Jul 25 '24 22:07 qndel

why touch all that whitespace stuff?

what?

kphoenix137 avatar Jul 25 '24 22:07 kphoenix137

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

qndel avatar Jul 25 '24 23:07 qndel

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

Please provide suggested changed and I'll commit

kphoenix137 avatar Jul 25 '24 23:07 kphoenix137

A word or two on what the issue is makes the log a bit more useful :)

AJenbo avatar Sep 02 '24 18:09 AJenbo