[Issue Report]: No differentiation between keymapper and padmapper in German translation

[Gunnar-GO]

Operating System

Windows x64

DevilutionX version

1.5.2

Describe

At the xbox port i have under options a dupe entry of control settings, "Tastaturbelegung" at least in the german translation, other i didn't checked before. This should be a minor, since is a dupe, so maybe an duped line etc.

Actually the Translation is not the best since at last half of the ports should use other controls than a keyboard.

To Reproduce

Go to settings.

Expected Behavior

1 entry

Additional context

No response

[StephenCWills]

It's not a duplicate entry, it's an issue with the translation.

https://github.com/diasurgical/devilutionX/blob/7211958a05c04bb3d3e94248462eb96ae281869c/Translations/de.po#L7198-L7212

Keymapper is for mouse-and-keyboard. Padmapper is for gamepad. So there needs to be two entries in the settings. The translation should differentiate between these two setups.

[qndel]

Also a screenshot or a pic would've been super helpful

[AJenbo]

@Gunnar-GO are you able to provide a better translation of the two words?

[Gunnar-GO]

@qndel i'm not sure if it was meant funny, but sure:

@AJenbo, uhm "Tastenbelegung" and "Controllerbelegung" or if keep an eye at the english one GamePad- / "Padbelegung" would fit to the last one also. Since the port targets doesn't have any keyboard may be it could also be hidden? (this point would fit for 3DS, vita, etc. also )

[AJenbo]

You can actually connect a keyboard to the original Xbox using a USB adapter and it will work with games that supports it. For Vita you can use Bluetooth. The 3DS even has an official keyboard.

Would you be willing to make the corrections to the German translation: https://github.com/diasurgical/devilutionX/blob/master/Translations/de.po Then I can approve an merge it.

[Entkoffeinator]

The 'keyboard section' is spot on. I would suggest the following for the gamepad assignment because there is no native word for "controller" in German, only the anglicism:

#: Source/options.cpp:1516 msgid "Padmapping" msgstr "Gamepadbelegung"

#: Source/options.cpp:1516 msgid "Padmapping Settings" msgstr "Gamepadbelegungseinstellungen"

[AJenbo]

I have applied @Entkoffeinator's suggestion here since no one else came forward with a PR for it: https://github.com/diasurgical/DevilutionX/commit/42954627c832560f70b7e76fbe49f9296d7aba19