devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Refactor: Check_Curs_Move (Issue: 1995)

Open Todd-C-Goldfarb opened this issue 1 year ago • 1 comments

In an effort to address this issue link: https://github.com/diasurgical/devilutionX/issues/1995

Refactored lots of functionality out into helper functions in cursor.cpp, small tweaks, but no big change to logic This is my first ever pull request, hoping to just get a bit of practice before I make a bigger contribution! (Tips and suggestions would be much appreciated)

Todd-C-Goldfarb avatar Jun 09 '24 17:06 Todd-C-Goldfarb

PR updated for clang formatting and consistent reference variable syntax.

Todd-C-Goldfarb avatar Jun 09 '24 19:06 Todd-C-Goldfarb

Thanks, I did a bit extra refactoring to change the code to use Point rather then int pairs, this also removed some redundant code.

AJenbo avatar Sep 22 '24 19:09 AJenbo