devilutionX Bugfix/Refactor: Min-Max Damage Range Calculations

Refactors damage calculations from the format: damage = min + rnd(max - min + 1) to: damage = randombetween(min, max)

Also fixes a bug in some damage calculations, where max damage in the range is 63/64th lower than it should be.

Mar 14 '24 22:03 kphoenix137

Looks like this made the demo run off the rails

Mar 14 '24 22:03 AJenbo

This likely addresses all the uses qndel identified in https://github.com/diasurgical/devilutionX/pull/6402 except the item.cpp changes, good to keep it focused for damage rolls.

Mar 14 '24 23:03 ephphatha

Looks like this made the demo run off the rails

Should be good now?

Mar 14 '24 23:03 kphoenix137

I think it would be nice to unify randomizing damage in the future - at the moment sometimes numbers are randomized before getting shifted, sometimes after, it's a mess - which means in some cases it's possible to get 1.5 dmg while in other places you'd get integers only - doesn't make much sense imo ;)

Mar 21 '24 20:03 qndel