devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Unify Arrow and Elemental Arrow Logic

Open kphoenix137 opened this issue 2 years ago • 4 comments

Built on: https://github.com/diasurgical/devilutionX/pull/6336 which moves missile damage into the Add functions from the Process functions

Previously, Arrow missiles and Elemental Arrow missiles were handled with separate functions. This moves Elemental Arrow logic into AddArrow() and ProcessArrow().

kphoenix137 avatar Jul 16 '23 00:07 kphoenix137

Any idea why it's breaking the demo?

AJenbo avatar Jul 19 '23 14:07 AJenbo

Any idea why it's breaking the demo?

No :(

kphoenix137 avatar Jul 20 '23 05:07 kphoenix137

Might just be because it was forked from a point where the test was broken in master. A rebase/merge should fix it.

AJenbo avatar Aug 29 '23 12:08 AJenbo

Did my best to rebase, please test and fix any issues i might have caused :/

AJenbo avatar Aug 29 '23 12:08 AJenbo