devilutionX
devilutionX copied to clipboard
diasurgical
Full translation revision
Full revision of the French translation: typos, translation checking, better phrasing, language level, translation of bits that weren't translated yet…
Wondering if @mmaret, @PegHorse or @echanaron would be willing to review it and see if the changes makes sens since I don't speak French :)
Hi What part should i read again ?
PegHorse ^^
Le jeu. 15 juin 2023 à 11:03, Anders Jenbo @.***> a écrit :
Wondering if @mmaret https://github.com/mmaret, @PegHorse https://github.com/PegHorse or @echanaron https://github.com/echanaron would be willing to review it and see if the changes makes sens since I don't speak French :)
— Reply to this email directly, view it on GitHub https://github.com/diasurgical/devilutionX/pull/6216#issuecomment-1592652893, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2SS3GOYCZYWRVP3TAFDHDXLLFVNANCNFSM6AAAAAAZHMNOCY . You are receiving this because you were mentioned.Message ID: @.***>
@PegHorse looks like @mmaret already reviewed the translation so I guess it's just optional if you want to have a look as well :)
I'm playing again and i notice "Niveau Supérieur" is not displayed entirely, the "R" is missing in the end while the translation is OK.
Le jeu. 15 juin 2023 à 18:32, Anders Jenbo @.***> a écrit :
@PegHorse https://github.com/PegHorse looks like @mmaret https://github.com/mmaret already reviewed the translation so I guess it's just optional if you want to have a look as well :)
— Reply to this email directly, view it on GitHub https://github.com/diasurgical/devilutionX/pull/6216#issuecomment-1593384714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2SS3CAOLXMQZ44PB5VQFDXLM2JXANCNFSM6AAAAAAZHMNOCY . You are receiving this because you were mentioned.Message ID: @.***>
Do you guys think this is ready to merge?
It seems there will be no more comments on this, so I gess it’s ready to merge.