devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Inconsistency in treating 0 charge staff

Open qndel opened this issue 2 years ago • 0 comments

Operating System

Windows x64

DevilutionX version

Custom build (please specify commit ID)

Describe

Commit https://github.com/diasurgical/devilutionX/commit/1e8230b9b1a18c54ac7fd4c8c6dc74970596fecc

If you save and load a game with 0 charges staff: image

In any other situation you don't have a selectable spell/icon for 0 charges

Comes from https://github.com/diasurgical/devilutionX/blob/master/Source/items.cpp#L2579 (no charges check) vs https://github.com/diasurgical/devilutionX/blob/master/Source/player.cpp#L3157 (charges check)

To Reproduce

  1. Get a staff
  2. Equip it
  3. Use all charges
  4. Save
  5. Load
  6. Check spells

Expected Behavior

No response

Additional context

No response

qndel avatar May 25 '23 21:05 qndel