devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

[improvement request] Close NPC window when clicking outside of it

Open MerleMoqueur opened this issue 1 year ago • 1 comments

It's currently necessary to click "say goodbye" or "leave […]" in the dialog window of the NPCs in town to leave them, which is a little bit rigid (especially when the player is used to Diablo II). A friendlier option would be to be allowed to just click outside the window in order to close it and leave the NPC.

MerleMoqueur avatar May 20 '23 09:05 MerleMoqueur

you can also press esc

AJenbo avatar May 20 '23 16:05 AJenbo

I agree 100% with this sentiment. I personally have found it annoying to have to press ESC a couple times or click the back/leave buttons to exit a shop. It's not conducive to the flow of gameplay in my opinion.

kphoenix137 avatar Aug 25 '23 19:08 kphoenix137

A bit surprised to see a couple downvotes on this one. @agris-codes and @FitzRoyX do you have any specific concerns about it?

Clicking outside windows to dismiss them is a fairly common UX pattern. Even though I'm used to pressing ESC by this point, I can see it not being very intuitive to a lot of folks.

Was wondering if there is maybe something I'm missing with this in terms of impact.

julealgon avatar Aug 30 '23 19:08 julealgon

@julealgon as if fitzroy would need a reason to downvote xD

qndel avatar Aug 30 '23 20:08 qndel

A bit surprised to see a couple downvotes on this one. @agris-codes and @FitzRoyX do you have any specific concerns about it?

Clicking outside windows to dismiss them is a fairly common UX pattern. Even though I'm used to pressing ESC by this point, I can see it not being very intuitive to a lot of folks.

Was wondering if there is maybe something I'm missing with this in terms of impact.

To me, it’s a solution in search of a problem. I agree it’s innocuous enough, but the general idea of brining 2020-era UX conventions to D1 slowly erodes its identify as a 1996 game. There’s a lot that’s already been done in that regard, like optional widescreen, xp bar, monster health bar with immunities; I could go on.

They are all optional and I understand why they exist, but this general notion of small tweaks to make function X or Y more palatable to current design trends should not be a guiding sentiment. Rather, it should be heavily scrutinized with a default assumption of OG 1996 behavior.

and ok, maybe I’m a keyboard supremacist :P

enough old man yells at clouds, but that’s why I downvoted

agris-codes avatar Aug 31 '23 15:08 agris-codes

We have a version of DevilutionX for people who don't like modernization. It's called Devilution.

kphoenix137 avatar Aug 31 '23 16:08 kphoenix137

A bit surprised to see a couple downvotes on this one. @agris-codes and @FitzRoyX do you have any specific concerns about it? Clicking outside windows to dismiss them is a fairly common UX pattern. Even though I'm used to pressing ESC by this point, I can see it not being very intuitive to a lot of folks. Was wondering if there is maybe something I'm missing with this in terms of impact.

To me, it’s a solution in search of a problem. I agree it’s innocuous enough, but the general idea of brining 2020-era UX conventions to D1 slowly erodes its identify as a 1996 game. There’s a lot that’s already been done in that regard, like optional widescreen, xp bar, monster health bar with immunities; I could go on.

They are all optional and I understand why they exist, but this general notion of small tweaks to make function X or Y more palatable to current design trends should not be a guiding sentiment. Rather, it should be heavily scrutinized with a default assumption of OG 1996 behavior.

and ok, maybe I’m a keyboard supremacist :P

enough old man yells at clouds, but that’s why I downvoted

Thanks for sharing @agris-codes .

Yeah... I guess we'll have to agree to disagree on some of those aspects. My view is that, as long as the change doesn't violate the original design, it should be mostly ok. Now.... I do admit this criteria is extremely subjective... perhaps to you it already fits in the "violates the original design" criteria.

Now... I do think that enabling widescreen and, especially, higher internal resolutions, massively impact the gameplay and I thus wouldn't put those in the same category. The fact that those are configurable alleviates some of the concerns though.

julealgon avatar Sep 09 '23 22:09 julealgon