devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Grammar issues with the "welcome to the" text block in some languages

Open MerleMoqueur opened this issue 1 year ago • 3 comments

In town, the top of the welcoming dialog boxes contain the "welcome to the" text block, with some name displayed underneath. For example:

  • Welcome to the + Rising Sun
  • Welcome to the + Blacksmith's shop

In some languages, this causes some issues, because of the grammatical gender of what follows.

For example, in French:

  • Bienvenue à la + Boutique du Forgeron (ok)
  • Bienvenue à la + Soleil Levant (not ok)

Or

  • Bienvenue au + Boutique du Forgeron (not ok)
  • Bienvenue au + Soleil Levant (ok)

Expected:

  • Bienvenue à la + Boutique du Forgeron
  • Bienvenue au + Soleil Levant

The problem is the same for Spanish, and I guess for most Romance languages.

A viable solution would be to not have the "welcome to the" in a separate text block and let the translator format the block in two lines as they feel.

welcome

MerleMoqueur avatar May 13 '23 07:05 MerleMoqueur

Similar to https://github.com/diasurgical/devilutionX/issues/4084 and https://github.com/diasurgical/devilutionX/issues/3563 Unfortunately, gettext (internationalization system used in this project) doesn't support grammatical gender.

@AJenbo talked about implementing Lua scripting for translations to fix these situations, probably in 1.6.0

tsunamistate avatar May 13 '23 08:05 tsunamistate

Hello,

I'm glad I found this because I was going through the classes translation and the gender is an issue. For example, in the parts were the rogue are discussed in spanish https://github.com/diasurgical/devilutionX/blob/1.5.0/Translations/es.po#L733 it says El Ladrón which is not the appropriate translation even. Looks like this line can be changed to the correct one but, will it still work with gettext? or its still an issue?

aoyawale avatar Jun 27 '23 21:06 aoyawale

For now it's not possible to provide gender specific translations.

AJenbo avatar Jun 27 '23 21:06 AJenbo