devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Broken level (Leorics tomb)

Open Chance4us opened this issue 2 years ago • 5 comments

Operating System

Linux x64

DevilutionX version

1.4.1 (latest release)

Describe

Started a new game on nightmare difficulty. Played to level 3 and saw something like this. leoric

I can't judge if it's a vanilla bug, for example a broken seed or something similar. A vanilla bug would of course be better, otherwise there might be an undesirable issue in our beautiful level generation code.

To Reproduce

Rare issue. Unclear whether reproducible.

Expected Behavior

No broken level

Additional context

Savegame: leoric.zip

EDIT: When walking around the tomb there is a "mirroring effect".

Chance4us avatar Aug 28 '22 08:08 Chance4us

This looks like it could be the same bug as what I reported recently with dlvl mutation in hellfire.

FitzRoyX avatar Aug 30 '22 15:08 FitzRoyX

This looks like it could be the same bug as what I reported recently with dlvl mutation in hellfire.

It looks like a very bad thing, is there any way to isolate the issue?

Chance4us avatar Aug 30 '22 15:08 Chance4us

Issues introduced here: 6ec782fb7a9228a0fea726244d09a70270305682 .. and 6fffbb4676f979019e9a8e007ffd84841a7e20d9

It's one of the more rare single chamber maps: image

AJenbo avatar Aug 30 '22 17:08 AJenbo

Is it like the quest structure has no place to go because the 4-pillar theme is getting placed first?

FitzRoyX avatar Aug 30 '22 21:08 FitzRoyX

Close, the issue was that I originally assumed that a level must have 2 chambers. We fixed that for the general level layout. The test case didn't have a quest piece and I missed fixing the same assumption later in the code where it picks between the available rooms.

In short because chamber 1 is missing, it assumes it should pick between 2 and 3. Leaving a 50% chance that it will pick a chamber that isn't actually there:

image

AJenbo avatar Aug 31 '22 00:08 AJenbo