devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Published 20 hours ago • verified publisher icon diasurgical

prevent items from going above 255 durability

Open qndel opened this issue 2 years ago • 2 comments

qndel avatar Mar 13 '22 14:03 qndel

Suggestion: create a value type called Durability and handle these concerns transparently inside the type with operator overloads. The same type could also abstract the "indestructible" concept more cleanly.

TL;DR: primitive obsession is bad.

julealgon avatar Jun 20 '22 04:06 julealgon

Suggestion: create a value type called Durability and handle these concerns transparently inside the type with operator overloads. The same type could also abstract the "indestructible" concept more cleanly.

TL;DR: primitive obsession is bad.

Feel free to make a PR ;)

qndel avatar Jun 20 '22 10:06 qndel