devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Fix Attack Speed Affix Panel Strings

Open kphoenix137 opened this issue 3 years ago • 7 comments

Changes Readiness & Swiftness to "fires quick speed arrows" & "fires fast speed arrows", on bow items in Hellfire.

kphoenix137 avatar Feb 28 '22 02:02 kphoenix137

This one probably could have stayed closed

DakkJaniels avatar Feb 02 '23 13:02 DakkJaniels

This one probably could have stayed closed

With the latest change to attack speed modifiers, yes

kphoenix137 avatar Feb 02 '23 13:02 kphoenix137

@AJenbo I would like to apologize, I completely forgot the contents of this PR. This will actually be a useful PR for Hellfire for displaying different Info Strings for bows that use fast attack speed in Hellfire. I just need to remove the info display changes for melee items. Can you reopen this?

kphoenix137 avatar Feb 03 '23 18:02 kphoenix137

sure, you should be able to as well

AJenbo avatar Feb 03 '23 18:02 AJenbo

case IPL_RNDARROWVEL: return _("fires random speed arrows"); Using this as a reference, what would be the best way of representing the increased arrow velocities in hellfire? We only have quick attack and fast attack flags. Here are some possible options: "Fires quick speed arrows" "Fires fast speed arrows"

"Fires faster speed arrows" "Fires fastest speed arrows"

"Quick arrow speed" "Fast arrow speed"

"Faster arrow speed" "Fastest arrow speed"

"Fast arrow speed" "Faster arrow speed"

I personally like the first option, since it matches the wording "quick" and "fast" that is found in the equivalent affixes on melee weapons, and the overall wording follows suit with the random arrow velocity string

kphoenix137 avatar Feb 03 '23 19:02 kphoenix137

Sounds good to me

AJenbo avatar Feb 03 '23 19:02 AJenbo

Sounds good to me

Changes are finalized, I'll just need to rebase (and possibly refactor) and it will be ready for review.

kphoenix137 avatar Feb 03 '23 19:02 kphoenix137