devilutionX
devilutionX copied to clipboard
diasurgical
line played in English with Polish sound pack on
Important information Android 11 / 1.3.0 / github release
Describe The line is played in English with the inventory full ('I have no room') instead of a Polish equivalent. No idea whether a translation is present in the Polish sound pack for that line though. So far this has been the only line played in English with the Polish sound pack on.
To Reproduce Steps to reproduce the behavior:
- Run Hellfire with the Polish sound pack, pick single user, play Warrior.
- Keep adding items to the inventory until full.
- The line played in English ('I have no room') indicates the problem.
Expected behavior Expected to hear a Polish equivalent from the sound pack.
That's because they didn't translate all sounds so whenever we tried to add some flavor with one of the unused ones, you'll get results like these.
There are other voice lines that still sound out in Polish for the said full inventory. Can you disable that one line so that it adds no foreign flavour to an otherwise flawless sound pack? Or at least add an option to blanket deny foreign sounds consistently.
There are other voice lines that still sound out in Polish for the said full inventory. Can you disable that one line so that it adds no foreign flavour to an otherwise flawless sound pack? Or at least add an option to blanket deny foreign sounds consistently.
Not really, that's why I recommended them to translate all sounds 🤷 You could always do it yourself by creating a patch_rt.mpq or user.mpq with that sound being an empty file
There are other voice lines that still sound out in Polish for the said full inventory. Can you disable that one line so that it adds no foreign flavour to an otherwise flawless sound pack? Or at least add an option to blanket deny foreign sounds consistently.
Not really, that's why I recommended them to translate all sounds 🤷
That would be ideal but until that happens the game will feature those occassional annoyances.
"until that happens" - it won't happen, they aren't working on the dubbing anymore and consider it finished
That's a shame, that makes it one more argument to allow excluding the few English lines that didn't make it via an ini param.
That's a shame, that makes it one more argument to allow excluding the few English lines that didn't make it via an ini param.
As I've said, it's not something we will be dealing with from our side, you can disable the sound from playing by replacing it with an empty one. 😛
FYI, here's a silent audio file. You should be able to use this to override the untranslated voice lines. https://github.com/diasurgical/devilutionX/blob/master/Packaging/ctr/audio_silent.wav
FYI, here's a silent audio file. You should be able to use this to override the untranslated voice lines. https://github.com/diasurgical/devilutionX/blob/master/Packaging/ctr/audio_silent.wav
Thank you, replacing it isn't that much of a deal to me, just thought known audio pack lapses such as this could be potentially controlled via a param (e.g. AudioFlavour=no), that's all
That would be a very obscure setting, we might instead add a blank sound or duplicate one of the similar lines.
There are a few more inventory related lines that have no translation ('what am I a pack rat?', 'where do you want me to put this?'). Seeing as there is no chance for these lines to ever be recorded by the PL audio pack artists, silencing them easily would be welcome. These add little story value anyway and are annoying after a few listens. I'm not versed in mpq patching.