devilutionX icon indicating copy to clipboard operation
devilutionX copied to clipboard

Log multiplayer events (player joined/left and chat)

Open Jmgr opened this issue 3 years ago • 6 comments

This logs player events (joined, left) and the chat, as well as player errors.

Fixes #672.

Jmgr avatar Apr 03 '21 09:04 Jmgr

Your indentation doesn't match

qndel avatar Apr 03 '21 09:04 qndel

I'm wondering if this should be behind a flag, or set to a specific log level like SDL_LogVerbose

AJenbo avatar Apr 03 '21 16:04 AJenbo

I'm wondering if this should be behind a flag, or set to a specific log level like SDL_LogVerbose

Can do, but this would be also applicable at other places I think. We could also add a debug log level that could help with debugging certain features. Happy to make this change for this PR though, as you want.

Jmgr avatar Apr 03 '21 22:04 Jmgr

I'm wondering if this should be behind a flag, or set to a specific log level like SDL_LogVerbose

Can do, but this would be also applicable at other places I think. We could also add a debug log level that could help with debugging certain features. Happy to make this change for this PR though, as you want.

tenor (2) https://pastebin.com/Xfdjsj1F Maybe parts of this can be reused

qndel avatar Apr 03 '21 22:04 qndel

https://github.com/diasurgical/devilutionX/pull/3722 Replaced with chatlog.

qndel avatar Feb 24 '22 19:02 qndel

This looks to be more about logging to an external place which #3722 doesn't deal with :)

AJenbo avatar Feb 24 '22 19:02 AJenbo