devilution icon indicating copy to clipboard operation
devilution copied to clipboard

SNetEnumProviders

Open 7keo opened this issue 6 years ago • 5 comments

the function is not defined in the storm header.

notes links it as 103, and then storm def links it to 105, but it's commented out.

which one to use?

7keo avatar Nov 02 '18 15:11 7keo

seems to be 105, will go with that for now and add it to storm header

7keo avatar Nov 02 '18 15:11 7keo

@mewmew , do you have and idea about where did the difference come from? @7keo , how have you decided to use 105?

sskras avatar Nov 15 '18 17:11 sskras

notes links it as 103, and then storm def links it to 105, but it's commented out.

which one to use?

I found the change: https://github.com/diasurgical/devilution/commit/2fe00515b1c92d86e8357cb0b9e4b9c349a12cbe#diff-70d7ffdaefa3d6270bc5a5455118eaa4

-  SNetEnumProviders             @103 NONAME
-  ;SNetEnumDevices               @104 NONAME
-  SNetEnumGames                 @105 NONAME
+  ;SNetEnumDevices               @103 NONAME
+  ;SNetEnumGames                 @104 NONAME
+  ;SNetEnumProviders             @105 NONAME

Looks like the original came from BWAPI and @squidcc and @galaxyhaxz explained the issue and the way to fix in https://github.com/diasurgical/devilution/pull/309#issuecomment-423362360 .

sskras avatar May 12 '19 07:05 sskras

Can this issue be closed?

sskras avatar May 12 '19 07:05 sskras

Ping @7keo

sskras avatar May 18 '19 15:05 sskras