sha.cpp

[AJenbo]

• [x] SHA1Clear
• [x] SHA1Result
• [x] SHA1Calculate
• [x] SHA1Input
• [ ] SHA1ProcessMessageBlock
• [x] SHA1Reset
• [x] SHA1Init

[glebm]

Perhaps SHA1ProcessMessageBlock needs to use DWORD internally instead of int:

	DWORD i, temp;
	DWORD W[80];
	DWORD A, B, C, D, E;

The current code in there does not calculate SHA1 (because it bit-shifts signed types instead of unsigned ones).

If this turns out to be the correct fix, it will break compatibility with existing devilution save games (due to signatures not matching).

Related: https://github.com/diasurgical/devilutionX/pull/341

[qndel]

it's not bin exact in vanilla

[AJenbo]

Blizzard SHA1 is notoriously broken compared to the standard, this issue affects most of there games afaik. Since we strive to be compatible with the original save games we can't really fix this either.

[glebm]

it's not bin exact in vanilla

Is the int version bin exact?

[qndel]

ofc, we got ALL functions in vanilla bin exact

[glebm]

Nice! What's the empty checkbox next to the function name referring to btw?

[qndel]

hellfire bin exact progress https://github.com/diasurgical/devilution/milestone/4