cat icon indicating copy to clipboard operation
cat copied to clipboard

release打的包有问题吧? Is there a problem with the package of the release?

Open StevenLuMT opened this issue 2 years ago • 2 comments

历史release的V3.1.0v4.0-RC1 都是基于cat/cat-client去发的包,这个cat/cat-client里的代码都很旧了,提供的api都不完整,比如com.dianping.cat.Cat这个主入口

cat/cat-client/src/main/java/com/dianping/cat/Cat.java cat/lib/java/src/main/java/com/dianping/cat/Cat.java 这俩什么区别,我看cat/lib/java/的代码都很新,是不是release错误?

Historical release V3.1.0 and v4.0-RC1 are all packages based on cat/cat-client. The code in this cat/cat-client is very old, and the APIs provided are incomplete, such as com.dianping.cat .Cat this main entrance

cat/cat-client/src/main/java/com/dianping/cat/Cat.java cat/lib/java/src/main/java/com/dianping/cat/Cat.java What is the difference between the two? I think the codes of cat/lib/java/ are very new. Is it a release error?

StevenLuMT avatar Feb 08 '23 08:02 StevenLuMT

cat-client/src/main/java/com/dianping/cat/Cat.java 是最新的V4.0-RC1版本

On Feb 8, 2023, at 16:34, StevenLuMT @.***> wrote:

我看历史release的V3.1.0 https://github.com/dianping/cat/releases/tag/3.1.0和v4.0-RC1 https://github.com/dianping/cat/releases/tag/v4.0-RC1 都是基于cat/cat-client去发的包,这个cat/cat-client里的代码都很旧了,提供的api都不完整,比如com.dianping.cat.Cat这个主入口

cat/cat-client/src/main/java/com/dianping/cat/Cat.java cat/lib/java/src/main/java/com/dianping/cat/Cat.java 这俩什么区别,我看cat/lib/java/的代码都很新,是不是release错误?

— Reply to this email directly, view it on GitHub https://github.com/dianping/cat/issues/2268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASQE75XWOUYGQUSEBLO3R3WWNLCRANCNFSM6AAAAAAUU6OUKQ. You are receiving this because you are subscribed to this thread.

qmwu2000 avatar Feb 09 '23 07:02 qmwu2000

cat-client/src/main/java/com/dianping/cat/Cat.java 是最新的V4.0-RC1版本 On Feb 8, 2023, at 16:34, StevenLuMT @.***> wrote: 我看历史release的V3.1.0 <https://github.com/dianping/cat/releases/tag/3.1.0>和v4.0-RC1 https://github.com/dianping/cat/releases/tag/v4.0-RC1 都是基于cat/cat-client去发的包,这个cat/cat-client里的代码都很旧了,提供的api都不完整,比如com.dianping.cat.Cat这个主入口 cat/cat-client/src/main/java/com/dianping/cat/Cat.java cat/lib/java/src/main/java/com/dianping/cat/Cat.java 这俩什么区别,我看cat/lib/java/的代码都很新,是不是release错误? — Reply to this email directly, view it on GitHub <#2268>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASQE75XWOUYGQUSEBLO3R3WWNLCRANCNFSM6AAAAAAUU6OUKQ. You are receiving this because you are subscribed to this thread.

@qmwu2000 哈喽,感觉不太对,那就是代码合并的问题? cat-client/src/main/java/com/dianping/cat/Cat.java这个类里,为啥没有这个logErrorWithCategory方法?看着迭代记录里没提到删除这个方法

StevenLuMT avatar Feb 20 '23 06:02 StevenLuMT