dialogic icon indicating copy to clipboard operation
dialogic copied to clipboard

Published 20 hours ago • verified publisher icon dialogic-godot

Can't seem to save timelines in Godot 4.0 A16, Dialogic 2.0 A1

Open assertchris opened this issue 1 year ago • 6 comments

The problem

Describe the bug When I create a timeline, I cannot save it.

To Reproduce Steps to reproduce the behavior:

  1. Create a couple characters
  2. Create a timeline
  3. Try to save timeline (cmd + s?)
  4. See error in console
  5. Switching to text editor and back erases visual editor contents6.

Expected behavior I expect the timeline to save

Screenshots Screenshot 2022-09-12 at 08 38 34

System (please complete the following information):

  • OS: macOS 12.5.1
  • Godot Version: 4.0 alpha 16
  • Dialogic Version: 2.0 alpha 1

Solutions

Workaround

I tried changing what was in the timeline, but the error seems to be the same no matter what I put in it.

assertchris avatar Sep 12 '22 06:09 assertchris

Have you tried with Alpha 2? it was released recently Interesting... Would it be possible to share your project so we can take a look?

coppolaemilio avatar Sep 12 '22 12:09 coppolaemilio

Yes, sorry that I didn't lead with that: https://github.com/assertchris/godot-experiments

I haven't integrated with Dialogic except for installing it as explained through the readme. My issue happens before I get to starting a timeline; with the creation of my first timeline.

assertchris avatar Sep 12 '22 13:09 assertchris

I think it should be resolved if you use the latest version from main since Godot Alpha 16 broke/rename some things

coppolaemilio avatar Sep 12 '22 13:09 coppolaemilio

Sorry for the confusion. I downloaded alpha 2, but the internal version seems to read alpha 1. This is on the latest version of both that I could download; but I'll try main and let you know what I find :)

Edit: would it be ok for me to mention Dialogic in a book about procedural content generation with Godot 4?

assertchris avatar Sep 12 '22 14:09 assertchris

would it be ok for me to mention Dialogic in a book about procedural content generation with Godot 4?

Of course! I hope that we can get it stable soon so that people can start using it without issues 😅

coppolaemilio avatar Sep 12 '22 14:09 coppolaemilio

alright, found your issue!

there's a variable set on the timeline to only go through saving if something's actually been changed. it was renamed at one point, and everywhere but two places got it updated

it'll be included in an update, but if you want to manually fix it in the mean time its this file, lines 110 and 112. remove the underscore before events_processed image

exelia-antonov avatar Sep 14 '22 02:09 exelia-antonov

Fixed by #1223

exelia-antonov avatar Sep 28 '22 19:09 exelia-antonov